fix(index): preserve persisted coverage summaries - #1326
Conversation
Signed-off-by: imi <hoshinoimi@gmail.com>
|
Reviewed — this is correct and merge-quality, and neither of its two failing checks is your fault. It is the cleanest of your four PRs. The loss is real on main, and I verified it rather than taking the issue's word for it. Your fix reads the authoritative persisted coverage, filters out the by-design I checked the memory handling specifically, since it is the kind of change where a borrowed pointer escapes: the borrowed On the two red checks — both non-genuine:
Everything else is green, including So: may we merge this as shown? It is still marked draft, which is the only thing holding it. If you were planning further changes, say so and I will wait. If draft is simply left over, mark it ready — or say the word here — and I will re-run CI and merge. For context on your other three: #1325 also came back MERGE with no defects and I have asked the same question there. #1323 is a sound fix that needs a rebase over #1173/#1176 plus a maintainer decision on full-scan semantics. #1324 has a real recall regression that our smoke suite caught — details on that thread. |
What does this PR do?
Fixes #1287.
The index response derived
parse_partial_countonly from errors produced by the current pipeline run. Incremental no-op and artifact-backed paths could consequently report zero even when persisted coverage rows still recorded parse gaps.This change loads the authoritative coverage summary from the stored graph when composing the response, with a run-local fallback if that read fails. By-design exclusions remain reported separately. A regression test covers an unchanged incremental run retaining its persisted partial-parse status.
Verification
make -f Makefile.cbm test-focused TEST_SUITES=index_resilience— 6 passedmake -f Makefile.cbm test-focused TEST_SUITES='cypher extraction registry pipeline mcp index_resilience'— 884 passed, 2 skippedChecklist
git commit -s) and follows the Contributor License Agreementmake -f Makefile.cbm test) — focused sanitized suites passedmake -f Makefile.cbm lint-ci) — not run locally